Skip to content

CLN: Remove unnecessary code #23696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2018
Merged

CLN: Remove unnecessary code #23696

merged 1 commit into from
Nov 14, 2018

Conversation

suminb
Copy link
Contributor

@suminb suminb commented Nov 14, 2018 •
edited
Loading

frozenset() and frozenset([]) essentially produce identical results, and thus there is no need to pass an empty list to create an empty frozenset.

  • tests added / passed (CI is still running...)
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry (no new feature)

@suminb
CLN: Remove unnecessary code
eddd732 
No need to pass an empty array to create an empty frozenset.
@pep8speaks
Copy link

Hello @suminb! Thanks for submitting the PR.

Line 62:18: E241 multiple spaces after ','

@jreback
Copy link
Contributor

jreback commented Nov 14, 2018

ok sure

@jreback jreback added the Clean label Nov 14, 2018
@codecov
Copy link

codecov bot commented Nov 14, 2018 •
edited
Loading

Codecov Report

Merging #23696 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23696      +/-   ##
==========================================
+ Coverage   92.24%   92.24%   +<.01%     
==========================================
  Files         161      161              
  Lines       51318    51340      +22     
==========================================
+ Hits        47339    47361      +22     
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.64% <100%> (ø) ⬆️
#single 42.34% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
pandas/core/groupby/groupby.py 96.51% <100%> (ø) ⬆️
pandas/core/accessor.py 98.79% <100%> (ø) ⬆️
pandas/core/generic.py 96.82% <100%> (ø) ⬆️
pandas/core/indexes/datetimelike.py 97.74% <0%> (-0.28%) ⬇️
pandas/tseries/offsets.py 96.98% <0%> (-0.09%) ⬇️
pandas/core/arrays/period.py 98.44% <0%> (-0.05%) ⬇️
pandas/core/indexes/datetimes.py 96.11% <0%> (-0.01%) ⬇️
pandas/core/arrays/datetimes.py 98.47% <0%> (+0.03%) ⬆️
pandas/core/arrays/datetimelike.py 96.14% <0%> (+0.21%) ⬆️
pandas/core/dtypes/concat.py 96.66% <0%> (+0.4%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302e4ca...eddd732. Read the comment docs.

jbrockmendel
jbrockmendel reviewed Nov 14, 2018
View reviewed changes
pandas/tests/dtypes/test_inference.py
@@ -59,7 +59,7 @@ def coerce(request):
({'a', 1}, 'set', 'set'), # noqa: E241
(set(), 'set', 'set-empty'), # noqa: E241
(frozenset({'a', 1}), 'set', 'frozenset'), # noqa: E241
(frozenset([]), 'set', 'frozenset-empty'), # noqa: E241
(frozenset(), 'set', 'frozenset-empty'), # noqa: E241
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the noqa still needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this has to do with liniing things up.

@jreback jreback added this to the 0.24.0 milestone Nov 14, 2018
@jreback jreback merged commit 3edc18d into pandas-dev:master Nov 14, 2018
@jreback
Copy link
Contributor

jreback commented Nov 14, 2018

thanks @suminb

@suminb suminb changed the title Remove unnecessary code CLN: Remove unnecessary code Nov 15, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@suminb @tm9k1
CLN: Remove unnecessary code (pandas-dev#23696)
c8933b6
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@suminb @Pingviinituutti
CLN: Remove unnecessary code (pandas-dev#23696)
de6627b
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@suminb @Pingviinituutti
CLN: Remove unnecessary code (pandas-dev#23696)
6d035fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@suminb @pep8speaks @jreback @jbrockmendel